Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve errors related to converting/uploading eCR FHIR messages #578

Merged
merged 2 commits into from
May 17, 2023

Conversation

BradySkylight
Copy link
Contributor

@BradySkylight BradySkylight commented May 16, 2023

PULL REQUEST

Summary

There are 3 separate errors reported here:

  1. Missing MedicationStatement.status - the MS FHIR Converter templates were missing the value set codes for MedicationStatement.status. I found the list on HL7's FHIR IG website and added them to the ValueSet file for the ECR templates within the MS FHIR Converter App.
  2. Missing DiagnositicReport.code - There was a bug in the default MS FHIR Converter template that was not evaluating the proper location for the codes for the DiagnosticReports. This has been updated to look in the proper location.
  3. Error: "Conditional operation on Practitioner was not attempted because search criteria was not selective enough." - according to the documentation on the HL7 FHIR IG webpage it appears this error occurs when: "Multiple matches: The server returns a 412 Precondition Failed error indicating the client's criteria were not selective enough preferably with an OperationOutcome" - I'm not sure if we can resolve this without seeing some of the data, however, this may be due to the issues listed above. I am unable, at this point to recreate this issue. We can retest once the fixes listed above are included to see if the issue is resolved.

Related Issue

Fixes Issue 133

Additional Information

The 3rd error could be related to update, create etc...however, I didn't think we were adding a section called if-none-exists section into our 'Request' section for each of the resources. Here is some more documentation about the different operations and WHY this error would result (see links below). I still think this may be resolved once we have proper resources being created with the FHIR Converter for the message(s) in question.

https://build.fhir.org/http.html#cond-update

https://build.fhir.org/http.html#ccreate

https://build.fhir.org/http.html#cond-patch

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #578 (7488875) into main (81fcbbb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #578   +/-   ##
=======================================
  Coverage   96.42%   96.42%           
=======================================
  Files          45       45           
  Lines        2492     2492           
=======================================
  Hits         2403     2403           
  Misses         89       89           
Flag Coverage Δ
unit-tests 96.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Collaborator

@emmastephenson emmastephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for addressing these Brady! Fingers crossed it also resolves that third issue.

@BradySkylight BradySkylight merged commit 52bfda6 into main May 17, 2023
@BradySkylight BradySkylight deleted the brady/fix-ecr-to-fhir-conversion-errors branch May 17, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Support]: upload_fhir_bundle error - deprecated expression
2 participants