Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

variable name change to be more consistent #649

Merged
merged 15 commits into from
Jun 15, 2023
Merged

Conversation

nickbristow
Copy link
Collaborator

PULL REQUEST

Summary

Changing variable names to match terraform

Related Issue

Fixes #

Additional Information

Anything else the review team should know?

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #649 (50aac1e) into main (ca1a48d) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 50aac1e differs from pull request most recent head f731614. Consider uploading reports for the commit f731614 to get more accurate results

@@           Coverage Diff           @@
##             main     #649   +/-   ##
=======================================
  Coverage   96.37%   96.37%           
=======================================
  Files          45       45           
  Lines        2539     2539           
=======================================
  Hits         2447     2447           
  Misses         92       92           
Flag Coverage Δ
unit-tests 96.37% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
phdi/fhir/geospatial/smarty.py 100.00% <100.00%> (ø)
phdi/geospatial/smarty.py 100.00% <100.00%> (ø)

Copy link
Collaborator

@KennethSkylight KennethSkylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@nickbristow nickbristow force-pushed the update-variable-names branch from b78e0eb to 56494f0 Compare June 9, 2023 21:28
@nickbristow nickbristow merged commit 3c08dcd into main Jun 15, 2023
@nickbristow nickbristow deleted the update-variable-names branch June 15, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants