Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove input from FHIR conversion error messaging to reduce noise #650

Merged
merged 9 commits into from
Jun 20, 2023

Conversation

gordonfarrell
Copy link
Collaborator

PULL REQUEST

Summary

Remove the full xml message input from the error output for FHIR conversion to reduce noise and make the actual error message more visible. The input is still able to be found through ADF or in the uploaded files.

Related Issue

Fixes https://app.zenhub.com/workspaces/dibbs-63f7aa3e1ecdbb0011edb299/issues/gh/cdcgov/phdi/621

Additional Information

Anything else the review team should know?

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #650 (ac32495) into main (b5d8270) will not change coverage.
The diff coverage is n/a.

❗ Current head ac32495 differs from pull request most recent head 2d4ab05. Consider uploading reports for the commit 2d4ab05 to get more accurate results

@@           Coverage Diff           @@
##             main     #650   +/-   ##
=======================================
  Coverage   96.37%   96.37%           
=======================================
  Files          45       45           
  Lines        2539     2539           
=======================================
  Hits         2447     2447           
  Misses         92       92           
Flag Coverage Δ
unit-tests 96.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@gordonfarrell gordonfarrell merged commit d9d65f5 into main Jun 20, 2023
@gordonfarrell gordonfarrell deleted the gordon/improve-fhir-conversion-errors branch June 20, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants