-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Api enhanced algo #656
Api enhanced algo #656
Conversation
I have literally no idea what's happening with the file in the assets folder. None of that should be changed. After the referenced PR lands, that's exactly how everything in the SDK should look. |
Codecov Report
@@ Coverage Diff @@
## main #656 +/- ##
=======================================
Coverage 96.37% 96.37%
=======================================
Files 45 45
Lines 2538 2539 +1
=======================================
+ Hits 2446 2447 +1
Misses 92 92
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
One thing that occurred to me is that you added more info to the test_bundle and I'm wondering how that fits in with the changes Brady (or maybe Kenneth) made to standardizing our test assets (if at all)?
@m-goggins I went back and did some digging on Kenneth's test standardizations, and it turns out that's for a different test generator. It's basically a helper function that loads up a list of lists array that we use in a couple of the helper function pandas tests. Whereas here, the changes I made are actually because I noticed that some of our test cases were outright missing patient info 😮 . One of the patients didn't have an MRN when they should have, and one of the patients had the same UUID as another patient for them, so it was correcting those errors that created changes in the test files here. |
Expose Enhanced Algo on Endpoint
Summary
This PR allows a user to invoke the DIBBs enhanced algorithm from a cloud endpoint with a new parameter in the input bundle.
Related Issue
Fixes #635
Additional Information
This PR is currently blocked by #655 , which makes some last SDK changes that this PR references. Once that PR lands, the requirements.txt file in this PR can be changed back to point to the main branch before merging.