Changing back to Python 3.10 #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #698 +/- ##
=======================================
Coverage 96.37% 96.37%
=======================================
Files 45 45
Lines 2539 2539
=======================================
Hits 2447 2447
Misses 92 92
Flags with carried forward coverage won't be shown. Click here to find out more. |
KennethSkylight
commented
Jul 7, 2023
| @@ -14,7 +14,7 @@ on: | |||
|
|
|||
|
|
|||
| env: | |||
| TEST_RUNNER_PYTHON_VERSION: 3.11 | |||
| TEST_RUNNER_PYTHON_VERSION: 3.10.12 | |||
There was a problem hiding this comment.
For some reason when I did just 3.10, it gave me an error saying it tried to test with python 3.1
So I just added the patch version so it wouldn't do that
DanPaseltiner
approved these changes
Jul 7, 2023
bamader
approved these changes
Jul 7, 2023
| @@ -5,7 +5,7 @@ azure-identity | |||
| typing_extensions==4.5.0 | |||
| pydantic==1.10.9 | |||
| fastapi==0.96.0 | |||
| phdi @ git+https://github.com/CDCgov/phdi@main | |||
| phdi @ git+https://github.com/CDCgov/phdi@python310 | |||
There was a problem hiding this comment.
Just a flag we'll have to change this back before merging
| @@ -1,6 +1,6 @@ | |||
| typing_extensions==4.6.3 | |||
| pydantic==1.10.9 | |||
| fastapi==0.96.0 | |||
| phdi @ git+https://github.com/CDCgov/phdi@main | |||
| phdi @ git+https://github.com/CDCgov/phdi@python310 | |||
nickbristow
pushed a commit
that referenced
this pull request
Jul 17, 2023
* changing back to 3.10 * gave patch version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.