Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eicr id in FHIR Converter and in ECR Datastore - add additional identifier fields #795

Merged
merged 7 commits into from
Sep 8, 2023

Conversation

BradySkylight
Copy link
Contributor

@BradySkylight BradySkylight commented Aug 29, 2023

PULL REQUEST

Summary

LAC Has requested that we include eICR set id to the ECR datastore and in so doing, we realized we may not have been pulling the correct fields for eICR id. We have made the following changes to fulfill LAC request and to include more identifiers:

FHIR Converter Changes

  1. Composition.id (FHIR) = ClincalDocument.id.root - This is the unique identifier for each eICR that may be related via an eICR Set Id - this is what should be used in the FHIR server to query for this specific resource.
  2. Composition.identifier.value = ClinicalDocument.setId.extension - this is the setId of a specific eICR that may be updated over time with additional/correcting information.
  3. Included the relatesTo slice for 'replaced' which includes the code 'replaces', reference to the composition resource being 'updated'/'replaced' (composition.id)
  4. Updated the assets files to reflect these changes for the ecr section for the FHIR Converter.

ECR Datastore Changes

  1. eicr_id now pulls the correct position of composition.id
  2. Added eicr_set_id which pulls from composition.idenfitifer
  3. Added replaced_eicr_id which is the full 'Reference' to the replaced eicr composition resource. The ID can be extracted from this field as needed.
  4. Added an replaced_eicr_version - which shows which version of the eicr is being replaced.

Related Issue

Fixes #https://app.zenhub.com/workspaces/skylight-dibbs-viper-6480ba23b5a07644e0e46d23/issues/gh/cdcgov/phdi-google-cloud/113

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #795 (bb5e895) into main (d4f41e1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #795   +/-   ##
=======================================
  Coverage   96.42%   96.42%           
=======================================
  Files          45       45           
  Lines        2626     2626           
=======================================
  Hits         2532     2532           
  Misses         94       94           
Flag Coverage Δ
unit-tests 96.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Collaborator

@m-goggins m-goggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! liquid is 😵

@BradySkylight
Copy link
Contributor Author

I have tested the resulting FHIR Bundle in our AZure FHIR server and it uploaded without any errors.

Copy link
Collaborator

@m-goggins m-goggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@BradySkylight BradySkylight merged commit 7983f93 into main Sep 8, 2023
@BradySkylight BradySkylight deleted the add-eicr-set-id branch September 8, 2023 19:08
@nickclyde nickclyde mentioned this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants