Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exception handling for XML parsing to FHIR Converter #839

Merged
merged 6 commits into from
Sep 29, 2023

Conversation

emmastephenson
Copy link
Collaborator

PULL REQUEST

Summary

Addresses a bug in the FHIR converter where it would throw a 500 if passed invalid XML for either the eCR or RR data.

Related Issue

No related ticket

Additional Information

The XMLSyntaxError is thrown by the phdi library during attempted RR extraction.

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #839 (91c15dc) into main (24499da) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #839   +/-   ##
=======================================
  Coverage   96.38%   96.38%           
=======================================
  Files          45       45           
  Lines        2628     2628           
=======================================
  Hits         2533     2533           
  Misses         95       95           
Flag Coverage Δ
unit-tests 96.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@emmastephenson emmastephenson marked this pull request as ready for review September 26, 2023 21:09
Copy link
Collaborator

@DanPaseltiner DanPaseltiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@BradySkylight BradySkylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why we didn't do this before! This is great to have! Thanks Emma!

@emmastephenson emmastephenson merged commit 2f9509d into main Sep 29, 2023
27 checks passed
@emmastephenson emmastephenson deleted the emma/fhir-converter-exception-handling branch September 29, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants