Added code to handle floats properly when making a list in the message parser #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to test schema and to test bundles to ensure the fix worked
Codecov Report
@@ Coverage Diff @@
## main #841 +/- ##
=======================================
Coverage 96.38% 96.38%
=======================================
Files 45 45
Lines 2628 2628
=======================================
Hits 2533 2533
Misses 95 95
Flags with carried forward coverage won't be shown. Click here to find out more. |
nickclyde
approved these changes
Sep 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
Nick identified a bug where if float values are present in a bundle that is processed that they can't be converted to a comma separate list of floats. The code now translates the floats into str to add them to a comma separated list. I have added tests to cover this case as well as a updated the test schema to include elements that are floats, additionally I have added lat and long to a sample test bundle for this test case.
My only concern is if this will cause issues downstream where we are reading this data from the message parser into files that LAC can consume. @m-goggins Can we confirm that this result will not break any of that functionality...if it does I can work with you on coming up with a solution.
See Error below:
Related Issue