Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select person id from patient table #896

Merged
merged 23 commits into from
Oct 31, 2023

Conversation

DanPaseltiner
Copy link
Collaborator

@DanPaseltiner DanPaseltiner commented Oct 31, 2023

PULL REQUEST

Summary

This PR makes a small modification to the base of the blocking query in the MPI. Currently we select person_id from the person table which requires that we do a JOIN between patient and person. However, since person_id is already included in patient as a foreign key we can simply select person_id from patient. Testing does not indicate that we will see a significant performance improvement from this change, but this is a simple change to make and eliminates a JOIN from our blocking query.

Related Issue

Fixes CDCgov/phdi-azure#323

Additional Information

Anything else the review team should know?

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

Copy link
Collaborator

@m-goggins m-goggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@DanPaseltiner DanPaseltiner merged commit ed4eeae into main Oct 31, 2023
18 checks passed
@DanPaseltiner DanPaseltiner deleted the select-person_id-from-patient-table branch October 31, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select person_id from patient table
2 participants