Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exception for result_metadata.effective_type. #6127

Merged
merged 3 commits into from
Jul 14, 2023
Merged

Add exception for result_metadata.effective_type. #6127

merged 3 commits into from
Jul 14, 2023

Conversation

rin-skylight
Copy link
Collaborator

@rin-skylight rin-skylight commented Jul 13, 2023 •
edited
Loading

DEVOPS PULL REQUEST

Related Issue

Changes Proposed

  • Add WAF exception for request argument result_metadata.effective_type.

Testing

  • This branch can be deployed to any environment with Metabase on it for appropriate testing.

Checklist for Primary Reviewer

Infrastructure

  • Consult the results of the terraform-plan job inside the "Terraform Checks" workflow run for this PR. Confirm that there are no unexpected changes!

Security

  • Changes with security implications have been approved by a security engineer (changes to authentication, encryption, handling of PII, etc.)

alismx
alismx approved these changes Jul 14, 2023
View reviewed changes
Copy link
Collaborator

@alismx alismx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

DanielSass
DanielSass approved these changes Jul 14, 2023
View reviewed changes
Copy link
Collaborator

@DanielSass DanielSass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, thanks Rin

@mehansen
Copy link
Collaborator

🙌 thank you!

@sonarcloud
Copy link

sonarcloud bot commented Jul 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@rin-skylight rin-skylight merged commit 7db812f into main Jul 14, 2023
33 checks passed
@rin-skylight rin-skylight deleted the rin/metabase_waf_exception branch July 14, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielSass DanielSass DanielSass approved these changes

@alismx alismx alismx approved these changes

@zdeveloper zdeveloper Awaiting requested review from zdeveloper

@mehansen mehansen Awaiting requested review from mehansen

@BobanL BobanL Awaiting requested review from BobanL

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add WAF exception to facilitate Metabase questions
4 participants
@rin-skylight @mehansen @DanielSass @alismx