1080: Update Read and send errors #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: jherrflexion <118225331+jherrflexion@users.noreply.github.com> Co-Authored-By: jcrichlake <145698165+jcrichlake@users.noreply.github.com> Co-Authored-By: Samuel Aquino <saquino@flexion.us> Co-Authored-By: Bella L. Quintero <96704946+pluckyswan@users.noreply.github.com>
… for Non Transient Errors Co-authored-by: Sylvie <sschuresko@flexion.us> Co-authored-by: jcrichlake <145698165+jcrichlake@users.noreply.github.com> Co-authored-by: pluckyswan <96704946+pluckyswan@users.noreply.github.com> Co-authored-by: James Herr <jherr@flexion.us>
pluckyswan
reviewed
Aug 19, 2024
|
|
||
| func (suite *SenderTestSuite) Test_SendMessage_StatusCodeIs400_ReturnsNonTransientError() { | ||
| sender, err := NewSender() | ||
| assert.NoError(suite.T(), err) |
There was a problem hiding this comment.
Is it necessary to check for errors after each step if it's not the target of the test?
There was a problem hiding this comment.
Asserts on test setup have been removed
Co-authored-by: Sylvie <sschuresko@flexion.us> Co-authored-by: pluckyswan <96704946+pluckyswan@users.noreply.github.com> Co-authored-by: James Herr <jherr@flexion.us> Co-authored-by: jbiskie <jbiskie@flexion.us>
Co-authored-by: Sylvie <sschuresko@flexion.us> Co-authored-by: jcrichlake <145698165+jcrichlake@users.noreply.github.com> Co-authored-by: pluckyswan <96704946+pluckyswan@users.noreply.github.com> Co-authored-by: James Herr <jherr@flexion.us> Co-authored-by: jbiskie <jbiskie@flexion.us>
|
pluckyswan
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates Read and Send Errors to move all Non Transient errors(error codes between 400 and 499) to the failure folder.
Issue
Issue 1080
Checklist
Note: You may remove items that are not applicable