remove admin_enabled #131
Merged
remove admin_enabled #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: jcrichlake <145698165+jcrichlake@users.noreply.github.com> Co-Authored-By: jherrflexion <118225331+jherrflexion@users.noreply.github.com> Co-Authored-By: halprin <halprin@users.noreply.github.com> Co-Authored-By: Samuel Aquino <saquino@flexion.us> Co-Authored-By: Bella L. Quintero <96704946+pluckyswan@users.noreply.github.com>
Co-Authored-By: jcrichlake <145698165+jcrichlake@users.noreply.github.com> Co-Authored-By: Bella L. Quintero <96704946+pluckyswan@users.noreply.github.com>
pluckyswan
reviewed
Aug 21, 2024
halprin
reviewed
Aug 22, 2024
| @@ -53,6 +52,8 @@ resource "azurerm_linux_web_app" "sftp" { | |||
| health_check_path = "/health" | |||
| health_check_eviction_time_in_min = 5 | |||
|
|
|||
| container_registry_use_managed_identity = true | |||
There was a problem hiding this comment.
Down below on what is currently line 84 and 85, we have...
DOCKER_REGISTRY_SERVER_USERNAME = azurerm_container_registry.registry.admin_username
DOCKER_REGISTRY_SERVER_PASSWORD = azurerm_container_registry.registry.admin_password
Can we remove those lines and this continues to work?
There was a problem hiding this comment.
We can try it and find out 😅
Co-Authored-By: jcrichlake <145698165+jcrichlake@users.noreply.github.com> Co-Authored-By: Bella L. Quintero <96704946+pluckyswan@users.noreply.github.com> Co-Authored-By: halprin <halprin@users.noreply.github.com> Co-Authored-By: Samuel Aquino <saquino@flexion.us>
Co-Authored-By: jcrichlake <145698165+jcrichlake@users.noreply.github.com> Co-Authored-By: Bella L. Quintero <96704946+pluckyswan@users.noreply.github.com> Co-Authored-By: halprin <halprin@users.noreply.github.com> Co-Authored-By: Samuel Aquino <saquino@flexion.us>
Co-Authored-By: jcrichlake <145698165+jcrichlake@users.noreply.github.com> Co-Authored-By: Bella L. Quintero <96704946+pluckyswan@users.noreply.github.com> Co-Authored-By: halprin <halprin@users.noreply.github.com> Co-Authored-By: Samuel Aquino <saquino@flexion.us>
Co-Authored-By: jcrichlake <145698165+jcrichlake@users.noreply.github.com> Co-Authored-By: Bella L. Quintero <96704946+pluckyswan@users.noreply.github.com> Co-Authored-By: halprin <halprin@users.noreply.github.com> Co-Authored-By: Samuel Aquino <saquino@flexion.us>
Co-authored-by: saquino0827 <saquino@flexion.us>
The Fortify rec is actually pretty vague - this is all it says |
|
pluckyswan
approved these changes
Aug 26, 2024
somesylvie
added a commit
that referenced
this pull request
Aug 26, 2024
This reverts commit a25f645.
somesylvie
added a commit
that referenced
this pull request
Aug 26, 2024
somesylvie
added a commit
that referenced
this pull request
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fortify wants us to not have
admin_enabledset totrueon the container registry. This PR changes that setting and turns oncontainer_registry_use_managed_identityinstead. To test this, we deployed to both a Flexion environment (this PR env) and a CDC one (dev) and confirmed the app deployed successfully and was runningIssue
CDCgov/trusted-intermediary#1209