Remove Non-Zip File from SFTP Sever #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f a non-zip file Co-authored-by: saquino0827 <saquino@flexion.us> Co-authored-by: James Herr <jherr@flexion.us> Co-authored-by: jcrichlake <145698165+jcrichlake@users.noreply.github.com> Co-authored-by: Sylvie <sschuresko@flexion.us>
1 task
jcrichlake
approved these changes
Sep 27, 2024
Co-authored-by: saquino0827 <saquino@flexion.us> Co-authored-by: James Herr <jherr@flexion.us> Co-authored-by: jcrichlake <145698165+jcrichlake@users.noreply.github.com> Co-authored-by: Sylvie <sschuresko@flexion.us>
|
somesylvie
approved these changes
Sep 27, 2024
|
/review |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| if err != nil { | ||
| slog.Error("Failed to remove file from local server", slog.Any(utils.ErrorKey, err), slog.String("name", fileInfo.Name())) | ||
| //delete file from local filesystem | ||
| err = os.Remove(fileInfo.Name()) |
There was a problem hiding this comment.
Consider adding a defer statement to handle file cleanup in a more reliable way. This ensures that the file is always removed regardless of where the function exits due to an error. [important]
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Non-Zip File from SFTP Sever
Description
Refactored copySingleFile to prevent early returning for a non-zip file when removing file from sftp server. Updated docker-compose to have consistent starting directory for sftp server. Tested locally to ensure that non-zip is ingested and deleted.
Issue
CDCgov/trusted-intermediary#1337
Checklist
Note: You may remove items that are not applicable