External sftp code and local config #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`copyfiles`; refactor some duplicate code; add placeholder env vars for SFTP; add placeholder calls to SFTP code Co-Authored-By: pluckyswan <96704946+pluckyswan@users.noreply.github.com> Co-Authored-By: halprin <halprin@users.noreply.github.com> Co-Authored-By: jcrichlake <145698165+jcrichlake@users.noreply.github.com>
… with folder structure Co-Authored-By: pluckyswan <96704946+pluckyswan@users.noreply.github.com> Co-Authored-By: halprin <halprin@users.noreply.github.com> Co-Authored-By: jcrichlake <145698165+jcrichlake@users.noreply.github.com> Co-Authored-By: jherrflexion <118225331+jherrflexion@users.noreply.github.com>
Co-Authored-By: halprin <halprin@users.noreply.github.com> Co-Authored-By: jcrichlake <145698165+jcrichlake@users.noreply.github.com>
Co-Authored-By: halprin <halprin@users.noreply.github.com> Co-Authored-By: jcrichlake <145698165+jcrichlake@users.noreply.github.com>
Co-Authored-By: pluckyswan <96704946+pluckyswan@users.noreply.github.com>
Co-Authored-By: pluckyswan <96704946+pluckyswan@users.noreply.github.com>
Co-Authored-By: pluckyswan <96704946+pluckyswan@users.noreply.github.com>
Co-authored-by: Sylvie <sschuresko@flexion.us> Co-authored-by: Rajeev Ranjan <rranjan@flexion.us> Co-authored-by: jcrichlake <145698165+jcrichlake@users.noreply.github.com> Co-authored-by: pluckyswan <96704946+pluckyswan@users.noreply.github.com> Co-authored-by: saquino0827 <saquino@flexion.us> Co-authored-by: James Herr <jherr@flexion.us>
Co-Authored-By: pluckyswan <96704946+pluckyswan@users.noreply.github.com> Co-Authored-By: jcrichlake <145698165+jcrichlake@users.noreply.github.com>
Co-Authored-By: pluckyswan <96704946+pluckyswan@users.noreply.github.com> Co-Authored-By: jcrichlake <145698165+jcrichlake@users.noreply.github.com> Co-Authored-By: Samuel Aquino <saquino@flexion.us>
Co-Authored-By: pluckyswan <96704946+pluckyswan@users.noreply.github.com>
saquino0827
reviewed
Jul 1, 2024
| @@ -3,7 +3,7 @@ set -e | |||
|
|
|||
| pushd ./src/ || exit | |||
|
|
|||
| THRESHOLD=50 | |||
| THRESHOLD=65 | |||
There was a problem hiding this comment.
Do we know what threshold we eventually want to reach? Is it the same as TI app?
There was a problem hiding this comment.
We don't have a specific number in mind. It will depend on how much code we have that is just pointing to an external library that we wouldn't want to test.
Co-Authored-By: pluckyswan <96704946+pluckyswan@users.noreply.github.com> Co-Authored-By: Samuel Aquino <saquino@flexion.us> Co-Authored-By: jcrichlake <145698165+jcrichlake@users.noreply.github.com> Co-Authored-By: jherrflexion <118225331+jherrflexion@users.noreply.github.com>
|
somesylvie
approved these changes
Jul 1, 2024
pluckyswan
approved these changes
Jul 1, 2024
saquino0827
approved these changes
Jul 1, 2024
jherrflexion
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External Partner SFTP and local config
We need to be able to connect to external SFTP clients and pull down files from them. This PR is the start of that work. It includes the code for retrieving data from an external SFTP server and copying it to our Azure storage container, plus config to enable local testing. We don't yet have credentials/info to set up connections to any customer's deployed environment.
Issue
SFTP issue
Checklist
Note: You may remove items that are not applicable