Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Production-ready authentication and authorization #20

Closed
JohnNKing opened this issue Oct 8, 2022 · 0 comments
Closed

Production-ready authentication and authorization #20

JohnNKing opened this issue Oct 8, 2022 · 0 comments

Comments

@JohnNKing
Copy link
Contributor

No description provided.

@JohnNKing JohnNKing closed this as not planned Won't fix, can't repro, duplicate, stale Nov 10, 2022
tjohnson7021 added a commit that referenced this issue Aug 15, 2024
- modified wording and format
- added additional context for Impact
basiliskus added a commit that referenced this issue Aug 22, 2024
* wip: add adrs for rule engines

* Updated template with Impact section

- added Impact section for revision improvement

* Updated template format for clarity

* Modified ADR #20

- modified wording and format
- added additional context for Impact

* Modified ADR #21

- reworded and modified format to include Impact

* Modified ADR #22

- Updated format
- Added content

* Updated validation engine ADR

* Updated transformation engine ADR

* Fixed a few typos

* Added another plus

* Fixed formatting and added impact considerations for ADR 001

---------

Co-authored-by: tjohnson7021 <tjohnson@flexion.us>
Co-authored-by: Tiffini Johnson <86614374+tjohnson7021@users.noreply.github.com>
jbiskie added a commit that referenced this issue Sep 12, 2024
jorg3lopez added a commit that referenced this issue Sep 28, 2024
* Create 020_CA_ORU_R01_CDPH_OBX_to_LOINC_0_initial_message.hl7

Copied from the previous set of HL7 test data, with added OBX examples of the new mapping

* Update 020_CA_ORU_R01_CDPH_OBX_to_LOINC_0_initial_message.hl7

Fixed typo on some local codes

* Adding translated example file #20

* Addin skeleton for transformation

* WIP - add initial implementation of MapLocalObservationCode transform

* Adding unit test for a single observation

* Adding test for local code mappable to a PLT

* Update MapLocalObservationCodes.java

Add the mapped coding at the beginning of the coding list

* Small code cleanup

* Add tests for when the initial code is a LOINC code

* Refactor tests to remove duplicated code

* Add assertion to evaluateCoding

* Adding test for when primary code is also populated

* Add tests for an unmapped local code and empty observation identifer

* Updates to transformation to pass first 2 test cases

* WIP - multiple observation test

* All curent tests pass, but the code is not pretty and has at least one edge case unnacounted for

* Complete the multiple observations test, add the remaining mappings to the lookup

* Minor cleanup and refactoring

* Replace for() loop with if check for a single coding on the observation

* Add MapLocalObservationCodes to transformation_definitions.json

* refactor:
logging for when local codes not found
added method to extract MSH10 to HapiHelper class

* Update sender in log warning, restore mock logger in unit tests

* Commenting out the PLT codes that haven't been mapped yet so they will cause warnings for now

* refactor helper method for msh10

* Minor naming tweaks and comment updates

* add null check for cwe extension

* Address null check for getSystem method

* Missing paren

* refactor:
added hascodingExtensionWithUrl helper method to HapiHelper
added getCodingExtensionByUrl helper method to HapiHelper

* refactor:
added hasCodingSytem helper method to HapiHelper
added getCodingSystem helper method to HapiHelper

* Removed comments and empty lines

* spotlessApply

* WIP: transform refactoring - flatten conditional blocks

* Refactor transform into simpler methods

* Update minor dependencies to v5.4 (#1339)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update HapiHelper.java

Replace unused assignment with inline return

* Update dependency com.azure:azure-storage-blob to v12.28.0 (#1344)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update Terraform azurerm to v4.3.0 (#1345)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Move urlForCodeType to HapiHelper for future reusability

* Adding tests for code coverage and addressing Sonar findings

* Adding tests for code coverage and addressing Sonar findings

* Adding tests for null and empty bundle for resourcesInBundle

* Adding tests for urlForCodeType

* HapiHelper: unit test for when bundle is null

* Updated RS Hurl Script to Replace MSH Header When Not Toggled (#1342)

* Updating hurl scripts
* Fixed typo in readme, create temp folder, write scrambled file into temp folder
* Fixed directory creation, resolved issue with sed command not copying rest of file
* updated readme to include toggle in options, add comments to scramble doing, alerted user to scrambling, removed folder creation for individual file
* replaced msh header for oru and orm message types
* added msh header replacement for oml message type
* switched to msh-9.2 as subfield in conditional
* remove temp directory after hurl script runs

---------

Co-authored-by: jcrichlake <jeff.crichlake@agile6.com>
Co-authored-by: Sylvie <sschuresko@flexion.us>
Co-authored-by: jcrichlake <145698165+jcrichlake@users.noreply.github.com>
Co-authored-by: saquino0827 <saquino@flexion.us>

* Add control id test, update test name

* Fix order of mockLogger registration and injection

* Fixed prod prefix mapping

Co-Authored-By: halprin <halprin@users.noreply.github.com>

* Add post-TI and post-RS example files

* Update dependency gradle to v8.10.2 (#1347)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Add final 5 PLT mappings; update mapping for 99717-50

* Add comment to clarify behavior of adding the mapped code

---------

Co-authored-by: Joel Biskie <jbiskie@flexion.us>
Co-authored-by: jorge Lopez <jlopez@flexion.us>
Co-authored-by: Tiffini Johnson <tjohnson@flexion.us>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Bella L. Quintero <96704946+pluckyswan@users.noreply.github.com>
Co-authored-by: jcrichlake <jeff.crichlake@agile6.com>
Co-authored-by: Sylvie <sschuresko@flexion.us>
Co-authored-by: jcrichlake <145698165+jcrichlake@users.noreply.github.com>
Co-authored-by: saquino0827 <saquino@flexion.us>
Co-authored-by: James Herr <jherr@flexion.us>
Co-authored-by: halprin <halprin@users.noreply.github.com>
Co-authored-by: Jorge Lopez <49923512+jorg3lopez@users.noreply.github.com>
tjohnson7021 added a commit that referenced this issue Oct 17, 2024
* Create 020_CA_ORU_R01_CDPH_OBX_to_LOINC_0_initial_message.hl7

Copied from the previous set of HL7 test data, with added OBX examples of the new mapping

* Update 020_CA_ORU_R01_CDPH_OBX_to_LOINC_0_initial_message.hl7

Fixed typo on some local codes

* Adding translated example file #20

* Addin skeleton for transformation

* WIP - add initial implementation of MapLocalObservationCode transform

* Adding unit test for a single observation

* Adding test for local code mappable to a PLT

* Update MapLocalObservationCodes.java

Add the mapped coding at the beginning of the coding list

* Small code cleanup

* Add tests for when the initial code is a LOINC code

* Refactor tests to remove duplicated code

* Add assertion to evaluateCoding

* Adding test for when primary code is also populated

* Add tests for an unmapped local code and empty observation identifer

* Updates to transformation to pass first 2 test cases

* WIP - multiple observation test

* All curent tests pass, but the code is not pretty and has at least one edge case unnacounted for

* Complete the multiple observations test, add the remaining mappings to the lookup

* Minor cleanup and refactoring

* Replace for() loop with if check for a single coding on the observation

* Add MapLocalObservationCodes to transformation_definitions.json

* refactor:
logging for when local codes not found
added method to extract MSH10 to HapiHelper class

* Update sender in log warning, restore mock logger in unit tests

* Commenting out the PLT codes that haven't been mapped yet so they will cause warnings for now

* refactor helper method for msh10

* Minor naming tweaks and comment updates

* add null check for cwe extension

* Address null check for getSystem method

* Missing paren

* refactor:
added hascodingExtensionWithUrl helper method to HapiHelper
added getCodingExtensionByUrl helper method to HapiHelper

* refactor:
added hasCodingSytem helper method to HapiHelper
added getCodingSystem helper method to HapiHelper

* Removed comments and empty lines

* spotlessApply

* WIP: transform refactoring - flatten conditional blocks

* Refactor transform into simpler methods

* Update minor dependencies to v5.4 (#1339)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update HapiHelper.java

Replace unused assignment with inline return

* Update dependency com.azure:azure-storage-blob to v12.28.0 (#1344)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update Terraform azurerm to v4.3.0 (#1345)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Move urlForCodeType to HapiHelper for future reusability

* Adding tests for code coverage and addressing Sonar findings

* Adding tests for code coverage and addressing Sonar findings

* Adding tests for null and empty bundle for resourcesInBundle

* Adding tests for urlForCodeType

* HapiHelper: unit test for when bundle is null

* Updated RS Hurl Script to Replace MSH Header When Not Toggled (#1342)

* Updating hurl scripts
* Fixed typo in readme, create temp folder, write scrambled file into temp folder
* Fixed directory creation, resolved issue with sed command not copying rest of file
* updated readme to include toggle in options, add comments to scramble doing, alerted user to scrambling, removed folder creation for individual file
* replaced msh header for oru and orm message types
* added msh header replacement for oml message type
* switched to msh-9.2 as subfield in conditional
* remove temp directory after hurl script runs

---------

Co-authored-by: jcrichlake <jeff.crichlake@agile6.com>
Co-authored-by: Sylvie <sschuresko@flexion.us>
Co-authored-by: jcrichlake <145698165+jcrichlake@users.noreply.github.com>
Co-authored-by: saquino0827 <saquino@flexion.us>

* Add control id test, update test name

* Fix order of mockLogger registration and injection

* Fixed prod prefix mapping

Co-Authored-By: halprin <halprin@users.noreply.github.com>

* Add post-TI and post-RS example files

* Update dependency gradle to v8.10.2 (#1347)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Add final 5 PLT mappings; update mapping for 99717-50

* Add comment to clarify behavior of adding the mapped code

---------

Co-authored-by: Joel Biskie <jbiskie@flexion.us>
Co-authored-by: jorge Lopez <jlopez@flexion.us>
Co-authored-by: Tiffini Johnson <tjohnson@flexion.us>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Bella L. Quintero <96704946+pluckyswan@users.noreply.github.com>
Co-authored-by: jcrichlake <jeff.crichlake@agile6.com>
Co-authored-by: Sylvie <sschuresko@flexion.us>
Co-authored-by: jcrichlake <145698165+jcrichlake@users.noreply.github.com>
Co-authored-by: saquino0827 <saquino@flexion.us>
Co-authored-by: James Herr <jherr@flexion.us>
Co-authored-by: halprin <halprin@users.noreply.github.com>
Co-authored-by: Jorge Lopez <49923512+jorg3lopez@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant