Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transformation to update OBR-2 with ORC-4 #1190

Merged
merged 13 commits into from
Jul 31, 2024
Merged

Conversation

basiliskus
Copy link
Contributor

@basiliskus basiliskus commented Jul 24, 2024

Transformation to update OBR-2 with ORC-4

There was a missing transformation for UCSD that we're adding here: Update OBR-2 with content from ORC-4 in the ORU result message. Replace OBR-2.1 with original content of ORC-4.1. Replace OBR-2.2 with original content of ORC-4.2. We are expanding the SwapPlacerOrderAndGroupNumbers transformation to include this changes

Issue

#1194

Checklist

  • I have added tests to cover my changes
  • I have added logging where useful (with appropriate log level)
  • I have added JavaDocs where required
  • I have updated the documentation accordingly

@basiliskus basiliskus marked this pull request as ready for review July 29, 2024 19:01
@jorg3lopez jorg3lopez changed the title Transformation to update OBR-2 with OCR-4 Transformation to update OBR-2 with ORC-4 Jul 30, 2024
"ORC.2",
"""
Bundle.entry.resource.ofType(ServiceRequest).identifier.where(type.coding.code = 'PLAC').value
"""),
PLACER_ORDER_NUMBER_OBR_2(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this path being used?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got no usages coming up too; Is this a question of whether we need this now or will need it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it is right now, but we're also using this FHIR paths as reference. Even if not used, it's useful for us to document all the HL7 FHIR paths

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ll approve the PR, but I would recommend that we add paths as and when they are needed. This way, we can ensure that every documented path is relevant and necessary at the time of its inclusion.

Copy link

sonarcloud bot commented Jul 31, 2024

Copy link
Contributor

@jorg3lopez jorg3lopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! The swap works as expected, good job.

@basiliskus basiliskus merged commit c436c91 into main Jul 31, 2024
16 checks passed
@basiliskus basiliskus deleted the add-obr-2-transformation branch July 31, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants