Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CA observation transforms from local code to LOINC or PLT #1306
CA observation transforms from local code to LOINC or PLT #1306
Changes from all commits
b3c2d0b
f3daa87
7d5d1ef
40c2656
1a602b7
7514d5b
aa5a9b8
5c177f9
9300a11
330c551
4af8afd
cb74b8f
4955e1b
00ef323
1902884
93aad56
5285140
fc64d6f
3a0c081
5eb84cc
e67a48d
2dcffa0
ffe4dfb
85ba878
a3b4f5d
79e1b30
653ad68
4e3bbcc
e349818
b8c5adb
fc4b6b2
b44c407
586e0ed
37f38c8
5764334
a94698f
377d2a7
92cfa89
f8f6592
581a900
6b15821
6eb52dd
2206175
4b627cc
40c3862
88eb350
1ab14fe
ebf0c78
43a3196
2321333
e03598f
70bec92
f16bf25
5741735
3522ae4
bc882ec
f353974
6b01894
cb222dd
d328552
bb1dc2c
9e281dd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd extract these identifier codes out into an enum so that if they get re-used and updated we don't have multiple places to change the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'd prefer if we do constants or leave as a HashMap until we move the config to the yaml or db.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these local codes only belong to UCSD. For that reason, we took the simple approach of having the map as part of the class. If other clients need to add their local codes as well, then that's when we can probably inject the map or enum to the class. But since the codes pertain to only one client, I think we can get away with leaving it as is. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we put a comment on this map so that other future devs know that these are all UCSD only values?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done