V3.5.11 beta #361
Merged
V3.5.11 beta #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix issue where address lines that include a comma are interpretted a…
fix issue with logos disappearing when other Org data is saved
fix issue with string token for model save errors
one could only share plan if it is 100% completed. When this is set in property config/initializers/_dmproadmap.rb, e.g., 188: config.x.plans.default_percentage_answered = 50. Fix for Roadmap bug DMPRoadmap#3086. In app/models/phase.rb method visibility_allowed?(plan) is broken because the first line in method always return 0 unless the Rational() is 1 in value = Rational(num_answered_questions(plan), plan.num_questions) * 100 Change: - we fix issue by converting the Rational() value to a float as follows value = Rational(num_answered_questions(plan), plan.num_questions).to_f * 100
…rg_visibility_plan_public_DMPs_only_appear_if_100_per_filled Roadmap bug 3086 - The share feature for Org plan visibility was broken:
…arch_result metadata standard does not always have locations
Update master prior to v3.1.1 (brakeman fails on end of life warning, so ignoring.)
…nts' page not allowing downloads unless the user is signed in
Fixes an issue preventing users from downloading templates from the Funder Requirements page
…ns duplicate plans in some cases. Fix for issue DMPRoadmap#3200. Changes in app/policies/api/v1/plans_policy.rb methods plans_for_client() and plans_for_user() returns a unique array of plan ids by finally calling the method uniq() on the ids the methods previously returned.
…ll_get_plans_returns_duplicates Bug DMPRoadmap#3200 - Fix for the V1 API call GET /api/v1/plans returns duplica…
updated dependencies and added brakeman exception for EOL rails
… groups optional subsets updates to prevent deletion of only non-optional subset tweak to logic when editing guidance_group tweak to logic when editing guidance_group tweak to logic when editing guidance_group tweak to logic when editing guidance_group added @guidance_groups to update and create so they are available during view render
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
sign-in-without-ssobranch which allows users to bypass SSO and use a password instead.<repositoryContact>elements so that the email address is usedThis update requires
bin/rails external_api:load_re3data_reposto be run to fix the contact info in therepositoriestable