Skip to content

Commit

Permalink
refactor error control
Browse files Browse the repository at this point in the history
  • Loading branch information
jsjiang committed Sep 26, 2023
1 parent 2dddd8d commit 7af59ec
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions ezidapp/management/commands/shoulder-check-minters.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import django.contrib.auth.models
import django.core.management
import django.db.transaction
from django.core.exceptions import ObjectDoesNotExist

import ezidapp.models.identifier
import ezidapp.models.shoulder
Expand Down Expand Up @@ -109,9 +110,13 @@ def check_minter(self, shoulder_model):
try:
minter = ezidapp.models.minter.Minter.objects.get(prefix=shoulder_model.prefix)
if shoulder_model.prefix != minter.prefix:
return "Minter error: shoulder.prefix != minter.prefix"
raise CheckError(
'Shoulder prefix does not match minter prefix',
f'shoulder.prefix: {shoulder_model.prefix}, minter.prefix: {minter.prefix}')
except ObjectDoesNotExist:
raise CheckError('No minter registered', f'No minter is registered for prefix: {shoulder_model.prefix}')
except Exception as ex:
return f'Minter error: No minter registered - Error: {ex}'
raise CheckError('Get minter failed', f'Get minter by prefix {shoulder_model.prefix} failed with error: {ex}')

try:
minted_id = impl.nog_sql.ezid_minter.mint_id(shoulder_model, dry_run=True)
Expand Down

0 comments on commit 7af59ec

Please sign in to comment.