Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

688 add location url to download #697

Merged
merged 7 commits into from
Aug 8, 2024
Merged

Conversation

jsjiang
Copy link
Contributor

@jsjiang jsjiang commented Aug 7, 2024

@sfisher Hi Scott,
This is to add target URL to the UI "Download all" functionality. This additional field is also become available to the batch download request since they share the same code.

Additional changes:

  • updated API guide template apidoc.2.rst
  • added rst2html to the requirements-dev.txt so we can run the make-apidoc-html command to generate the apidoc2.htm file
  • created the apidoc2.htm file
  • updated pyproject.toml and poetry.lock files

Here is the requirements ticket [FEATURE] Include the resolved URLs (Locations) in UI "Download All" functionality #688

The branch 688_add_location_url_to_download is deployed on ezid-dev. You can test it in two ways:

  • Logon to EZID UI https://ezid-dev.cdlib.org/ , go to "Manage IDs" page, click "Download All"
  • Use the batch-download.sh script in the ezid-client-tool repo. You would need to change the hostname from ezid to ezid-dev. Here is sample command:
./batch-download.sh apitest apitest format=csv column=_id column=_mappedTitle co
lumn=_target notify=your_email_address

Let me know if you have questions or notice any issues.

Thank you

Jing

@jsjiang jsjiang requested a review from sfisher August 7, 2024 18:34
Copy link
Contributor

@sfisher sfisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, Jing.

I tested through the UI and the report had the target URLs.

Thanks for making this modification.

@jsjiang jsjiang merged commit 8cdfd15 into develop Aug 8, 2024
2 checks passed
@jsjiang jsjiang deleted the 688_add_location_url_to_download branch August 28, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants