Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change link checker update job to run 15 hours after midnight #732

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

jsjiang
Copy link
Contributor

@jsjiang jsjiang commented Sep 11, 2024

@sfisher Hi Scott, this is to schedule the link checker update to restart at 3pm (15 hours after midnight). See lines 545-548 in the setting.py.j2 file for the explanation. The value is used in the proc-link-chekcer.py script to calculate time to sleep before next run.

I have deployed tag link-checker-update on ezid-stg with this setting and the proc-link-chekcer job was started at 3pm as expected.

Please take a look and let me know if you have questions.

Thank you

Jing

@jsjiang jsjiang requested a review from sfisher September 11, 2024 22:24
Copy link
Contributor

@sfisher sfisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks for explaining it all to me, Jing.

@jsjiang
Copy link
Contributor Author

jsjiang commented Sep 12, 2024

@sfisher Hi Scott,
The link-checker-update job was restarted by itself today at 3pm. So the setting worked. I changed the start time from 15 hours after midnight to 18 hours (64,800 sec) to avoid a conflict with Prod OS patching which happens once a month on the first Tuesday 3-5pm.

Also I changed a filename in the tests/util folder so it will not be picked up by pytest.

I will merge the change and I am planning to run prod deploy Monday 9/16 in the morning.

Thank you

Jing

@jsjiang jsjiang merged commit e9a15cc into develop Sep 12, 2024
2 checks passed
@sfisher
Copy link
Contributor

sfisher commented Sep 13, 2024

Thank you, Jing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants