Fixes a problems with reports #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge Develop to main for link-checker-update schedule change
…etc is maintained if resetting time frame
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two problems with the reports for #718 .
Makes it so login is required to view reports and eliminates errors with no user.
It makes it so that changing the date drop-downs for the report lower in the page does not reset the group/realm setting in the upper part of the page.
The reports are not exactly consistent in what they show and I think it's on purpose since they are actually kind of separate reports that have been glommed into one page.
See the explanation in the ticket and we can decide if it's worth reworking them or just make it more clear what each report entails.
The CSV report always includes all items that the user has access to.
The second section (summary) heeds the group/realm settings but gives stats for all time.
The third section with the inline HTML table with stats heeds the group/realm settings and also the dates right above it (and nothing else on the page uses those dates).
If we decide to just make it clearer, I can add explanatory text for the sections and add to the PR.