Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade python package and dependencies #743

Merged
merged 1 commit into from
Oct 1, 2024
Merged

upgrade python package and dependencies #743

merged 1 commit into from
Oct 1, 2024

Conversation

jsjiang
Copy link
Contributor

@jsjiang jsjiang commented Sep 30, 2024

@sfisher Hi Scott,
The Python version ^3.11 was manually updated in the pyproject.toml file. Other changes were made by running the update_pyproject.sh command which calls the poetry add {package}@latest and poetry update commands.

Please review and let me know if you have questions.

Thank you

Jing

@jsjiang jsjiang requested a review from sfisher September 30, 2024 23:00
sfisher
sfisher approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@sfisher sfisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I tested on my computer and also on dev machine and I believe everything is working.

@jsjiang jsjiang merged commit 3f94d46 into develop Oct 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfisher sfisher sfisher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsjiang @sfisher