Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add proc-cleanup-async-queues_v2.py with data range #765

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

jsjiang
Copy link
Contributor

@jsjiang jsjiang commented Oct 8, 2024

@sfisher Hi Scott,
This script is derived from the proc-cleanup-async-queues.py and will be used for async queue data cleanup.

The command takes 3 parameters:

  • page size: optional which will be used to test database performance on different batch sizes
  • updated_from and updated_to: required when we work on batch data cleanup

The sleep logic when the queryset reaches to its end (if not refIdsQS) may need refactoring for production implementation. This will affect when to rerun the job.

For the batch data cleanup, we should terminate the process when the queryset reaches to its end.

            if not refIdsQS:
                break

Please review and let me know if you have questions.

@jsjiang jsjiang requested a review from sfisher October 8, 2024 23:49
Copy link
Contributor

@sfisher sfisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks ok. I tried comparing with the proc-cleanup-async-queues where it was the same and looking at changes.

I think the flexibility to change dates and run with the arguments is great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants