Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

774 fix contact form email issue #776

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Conversation

jsjiang
Copy link
Contributor

@jsjiang jsjiang commented Oct 31, 2024

@sfisher Hi Scott,
Here are the changes:

  • replace the wrapper function django.core.mail.send_mail() which does not support reply_to with the lower level class EmailMessage. We need the the reply_to field to store user entered email which will be used to generate help desk email
  • bug fix to the proc-cleanup-async-queues_v2.py script - the last_id = refId.pk statement should be inside the loop otherwise "None" error will be generated when query returns no results.

Please review and let me know if you have questions.

Thank you

Jing

@jsjiang jsjiang requested a review from sfisher October 31, 2024 18:48
Copy link
Contributor

@sfisher sfisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for replacing this function. It sounds like Adam got the emails and it is working.

It make sense for the other one to put it inside the loop so it's not None.

@jsjiang jsjiang merged commit 7c469ec into develop Oct 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants