Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] support column encryption #202

Merged
merged 3 commits into from
Jul 23, 2022
Merged

Conversation

dk-lockdown
Copy link
Collaborator

@dk-lockdown dk-lockdown commented Jul 14, 2022

ref: #24

Ⅰ. Describe what this PR did

INSERT INTO departments (id,dept_no,dept_name) VALUES (1,'1001','sunset')

will be rewrite to:

INSERT INTO departments (id,dept_no,dept_name) VALUES (1,'1001','3d244141cb5b6f921923f7f88f073941')
UPDATE departments SET dept_name='moonlight' WHERE id=1

will be rewrite to:

UPDATE departments SET dept_name='5cdeb84b8fc3c22fd6c3e37ca6d837da' WHERE id=1

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

check ci result

Ⅴ. Special notes for reviews

@dk-lockdown dk-lockdown added the WIP Work in progess label Jul 14, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2022

Codecov Report

Merging #202 (dc08117) into dev (d4a162b) will decrease coverage by 0.52%.
The diff coverage is 25.00%.

❗ Current head dc08117 differs from pull request most recent head c407313. Consider uploading reports for the commit c407313 to get more accurate results

@@            Coverage Diff             @@
##              dev     #202      +/-   ##
==========================================
- Coverage   42.68%   42.15%   -0.53%     
==========================================
  Files          81       82       +1     
  Lines        9606     9804     +198     
==========================================
+ Hits         4100     4133      +33     
- Misses       5099     5248     +149     
- Partials      407      423      +16     
Impacted Files Coverage Δ
pkg/executor/sharding.go 0.00% <0.00%> (ø)
pkg/filter/dt/filter_http_transaction.go 0.00% <ø> (ø)
pkg/misc/crypto.go 0.00% <0.00%> (ø)
pkg/misc/hint.go 0.00% <0.00%> (ø)
pkg/executor/misc.go 32.14% <17.39%> (-67.86%) ⬇️
pkg/executor/single_db.go 49.11% <55.55%> (+1.22%) ⬆️
pkg/executor/read_write_splitting.go 46.25% <58.97%> (-0.09%) ⬇️
pkg/plan/result.go 63.80% <80.00%> (ø)

@dk-lockdown dk-lockdown force-pushed the feature/crypto branch 3 times, most recently from 391b684 to 433fe31 Compare July 14, 2022 13:30
@dk-lockdown dk-lockdown changed the title [WIP] support insert column encryption [WIP] support column encryption Jul 15, 2022
@dk-lockdown dk-lockdown marked this pull request as ready for review July 21, 2022 09:58
@dk-lockdown dk-lockdown added enhancement New feature or request and removed WIP Work in progess labels Jul 21, 2022
Copy link
Collaborator

@bohehe bohehe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dk-lockdown dk-lockdown merged commit 723b370 into CECTC:dev Jul 23, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants