-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] support column encryption #202
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #202 +/- ##
==========================================
- Coverage 42.68% 42.15% -0.53%
==========================================
Files 81 82 +1
Lines 9606 9804 +198
==========================================
+ Hits 4100 4133 +33
- Misses 5099 5248 +149
- Partials 407 423 +16
|
dk-lockdown
force-pushed
the
feature/crypto
branch
3 times, most recently
from
July 14, 2022 13:30
391b684
to
433fe31
Compare
dk-lockdown
changed the title
[WIP] support insert column encryption
[WIP] support column encryption
Jul 15, 2022
dk-lockdown
force-pushed
the
feature/crypto
branch
from
July 21, 2022 09:46
5e1dfcb
to
b2c5fa3
Compare
dk-lockdown
force-pushed
the
feature/crypto
branch
from
July 21, 2022 09:53
b2c5fa3
to
c407313
Compare
dk-lockdown
requested review from
bohehe,
fatelei,
hzliangbin,
wybrobin,
zackzhangkai and
zhu733756
July 21, 2022 09:58
dk-lockdown
added
enhancement
New feature or request
and removed
WIP
Work in progess
labels
Jul 21, 2022
bohehe
approved these changes
Jul 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fatelei
approved these changes
Jul 23, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #24
Ⅰ. Describe what this PR did
will be rewrite to:
will be rewrite to:
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
check ci result
Ⅴ. Special notes for reviews