feat: add prometheus metric #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
dk-lockdown
reviewed
May 9, 2022
|
I have read the CLA Document and I hereby sign the CLA |
dk-lockdown
reviewed
May 9, 2022
fatelei
force-pushed
the
dev_metric
branch
3 times, most recently
from
33a2862
to
ddcff48
Compare
|
the test metric is below:
|
dk-lockdown
reviewed
May 10, 2022
dk-lockdown
reviewed
May 10, 2022
dk-lockdown
reviewed
May 10, 2022
fatelei
force-pushed
the
dev_metric
branch
3 times, most recently
from
c004042
to
071b05d
Compare
|
ConnectionMetricFilter should be add first position of filters array |
dk-lockdown
reviewed
May 10, 2022
Codecov Report
@@ Coverage Diff @@
## dev #48 +/- ##
=======================================
Coverage 34.22% 34.22%
=======================================
Files 42 42
Lines 4947 4947
=======================================
Hits 1693 1693
Misses 3085 3085
Partials 169 169 Continue to review full report at Codecov.
|
bohehe
approved these changes
May 11, 2022
|
LGTM |
zhu733756
reviewed
May 11, 2022
|
file formatted, i add |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #25
Ⅰ. Describe what this PR did
add prometheus metric for dbpack. opentelemetry metric currently unstable
Ⅱ. Does this pull request fix one issue?
#25
Ⅲ. Why don't you add test cases (unit test/integration test)?
no need tests
Ⅳ. Describe how to verify it
in my computer, i verify it
Ⅴ. Special notes for reviews
connection metric filter config
