Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixbug: should use db connection rather than tx connection exec sql r… #8

Merged
merged 3 commits into from
Apr 22, 2022

Conversation

dk-lockdown
Copy link
Collaborator

…equest

ref: https://github.com/cectc/dbpack/issues/

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2022

Codecov Report

Merging #8 (7873fad) into dev (045ab6a) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##              dev       #8   +/-   ##
=======================================
  Coverage   57.34%   57.34%           
=======================================
  Files          19       19           
  Lines        1395     1395           
=======================================
  Hits          800      800           
  Misses        576      576           
  Partials       19       19           
Impacted Files Coverage Δ
pkg/executor/read_write_splitting.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 045ab6a...7873fad. Read the comment docs.

@dk-lockdown dk-lockdown merged commit 52d78ca into CECTC:dev Apr 22, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants