Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move samples to dbpack-samples #81

Merged
merged 2 commits into from
May 22, 2022
Merged

move samples to dbpack-samples #81

merged 2 commits into from
May 22, 2022

Conversation

JuwanXu
Copy link
Contributor

@JuwanXu JuwanXu commented May 22, 2022

ref: #62

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@github-actions
Copy link
Contributor

github-actions bot commented May 22, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@JuwanXu
Copy link
Contributor Author

JuwanXu commented May 22, 2022

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request May 22, 2022
@JuwanXu
Copy link
Contributor Author

JuwanXu commented May 22, 2022

recheck

@codecov-commenter
Copy link

codecov-commenter commented May 22, 2022

Codecov Report

Merging #81 (8ff4e55) into dev (76ced49) will increase coverage by 0.31%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev      #81      +/-   ##
==========================================
+ Coverage   38.39%   38.70%   +0.31%     
==========================================
  Files          47       47              
  Lines        5774     5774              
==========================================
+ Hits         2217     2235      +18     
+ Misses       3357     3339      -18     
  Partials      200      200              
Impacted Files Coverage Δ
pkg/misc/sql.go 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76ced49...8ff4e55. Read the comment docs.

Copy link
Collaborator

@dk-lockdown dk-lockdown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@bohehe bohehe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dk-lockdown dk-lockdown merged commit 1eeb6d2 into CECTC:dev May 22, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants