Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add readiness and liveness probe #83

Merged
merged 1 commit into from
May 24, 2022
Merged

Conversation

hzliangbin
Copy link
Contributor

@hzliangbin hzliangbin commented May 22, 2022

Signed-off-by: hzliangbin hzliangbin@foxmail.com

ref: #52

Ⅰ. Describe what this PR did

add readiness and liveness probe

Ⅱ. Does this pull request fix one issue?

#52

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@github-actions
Copy link
Contributor

github-actions bot commented May 22, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

cmd/healthcheck.go Show resolved Hide resolved
cmd/metrics.go Show resolved Hide resolved
cmd/routes.go Show resolved Hide resolved
@hzliangbin
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@hzliangbin hzliangbin changed the title [WIP] feat: add readiness and liveness probe feat: add readiness and liveness probe May 23, 2022
cmd/healthcheck.go Outdated Show resolved Hide resolved
cmd/routes.go Outdated Show resolved Hide resolved
cmd/metrics.go Outdated Show resolved Hide resolved
Signed-off-by: hzliangbin <hzliangbin@foxmail.com>
@fatelei
Copy link
Collaborator

fatelei commented May 24, 2022

some comment not resolve

@adofsauron
Copy link

LGTM

@fatelei
Copy link
Collaborator

fatelei commented May 24, 2022

LGTM

@dk-lockdown dk-lockdown merged commit f43ab5f into CECTC:dev May 24, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants