Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

header - update minor version in header definition #732

Merged
merged 1 commit into from
Apr 8, 2021
Merged

header - update minor version in header definition #732

merged 1 commit into from
Apr 8, 2021

Conversation

jeremylt
Copy link
Member

@jeremylt jeremylt commented Apr 7, 2021

No description provided.

@jeremylt jeremylt requested a review from jedbrown April 7, 2021 21:27
@jeremylt jeremylt self-assigned this Apr 7, 2021
@jeremylt
Copy link
Member Author

jeremylt commented Apr 7, 2021

This should be added to #725

jedbrown
jedbrown approved these changes Apr 8, 2021
View reviewed changes
Copy link
Member

@jedbrown jedbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn, thanks for catching. Making this authoritative would be nice.

@jedbrown jedbrown merged commit 240131b into main Apr 8, 2021
@jedbrown jedbrown deleted the jeremy/header-version branch April 8, 2021 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedbrown jedbrown jedbrown approved these changes

Assignees

@jeremylt jeremylt

Labels
1-In Review bug minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremylt @jedbrown