-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vec - add CeedVectorScale #757
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rust binding?
4dc27a7
to
9c61a40
Compare
9c61a40
to
2ac872f
Compare
I updated the Python tests, added some Rust bindings, and fixed a Rust CI issue. We're currently having intermittent readthedocs issues, so I merging is currently blocked on this PR. |
Nice. Should this also be added to |
The Julia bindings won't actually build locally for me. Let's see if CI thinks I did it right |
I had some problems with |
8379240
to
2ac872f
Compare
Because of the way the Julia bindings are tested, I looks like I can't just add development features. I'll let @pazner decide if/when/how to add these three convenience functions [CeedVectorScale, CeedVectorAXPY, CeedVectorPointwiseMult]. FFI in Julia seems to be far more painful than FFI in Python or Rust. |
I could try to help with these issues if you have some more details to share. |
I added these new functions to LibCEED.jl. I also added the distinction between "development tests" and "release tests" for the Julia interface. Release tests are those tests that use only the library features from the most recent release. That way, these tests are run both against the most recent binary build of libCEED_jll and against the current build in the CI. On the other hand, development tests are tests for features which have been introduced since the latest release, and are not available in the binary build. These are run in the CI only with the current build of the library. After each new release, the development tests can become release tests. This is documented in the release procedures in #725. |
Hi @pazner , yes, I haven't had the time to give it another try since my first attempt a while ago. I will try again and will report on that, if I still encounter issues. Thanks! |
Thanks @pazner. Do we need the generated file committed in the repository? |
Thanks. Is the issue that |
One issue is that it would add a dependency on Some of these issues could be worked around, but it's not clear that the benefit would be worth the (significant) added complexity. While it may not be the most "elegant" solution, I believe including the generated files in the repo is the most common approach for packages that wrap a C API. I think the process could be automated (or at least made more automatic than it currently is). We could try to do some checks in the CI. Of course, these files (at least the parts of them that are used by the Julia interface) are tested with the unit tests, so we do have some level of confidence that they didn't get messed up somehow. |
47bb7ea
to
d821f45
Compare
d821f45
to
891038d
Compare
Another convenience vector method