clean up log callbacks #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This second logging callback is never set. Fixes: 0553277 log FEATURE supply session as log clb parameter
jktjkt
added a commit
to CESNET/CzechLight-dependencies
that referenced
this pull request
Apr 10, 2024
Change-Id: I64fc283d17075bd5236243cc7072b11b53570e48 Depends-on: https://gerrit.cesnet.cz/c/CzechLight/libyang-cpp/+/7049 Depends-on: https://gerrit.cesnet.cz/c/CzechLight/sysrepo-cpp/+/7033 Depends-on: https://gerrit.cesnet.cz/c/CzechLight/libnetconf2-cpp/+/7041 Depends-on: CESNET/libnetconf2#477 Depends-on: CESNET/libnetconf2#478
jktjkt
added a commit
to CESNET/CzechLight-dependencies
that referenced
this pull request
Apr 10, 2024
Change-Id: I64fc283d17075bd5236243cc7072b11b53570e48 Depends-on: https://gerrit.cesnet.cz/c/CzechLight/libyang-cpp/+/7049 Depends-on: https://gerrit.cesnet.cz/c/CzechLight/sysrepo-cpp/+/7033 Depends-on: https://gerrit.cesnet.cz/c/CzechLight/libnetconf2-cpp/+/7041 Depends-on: CESNET/libnetconf2#477 Depends-on: CESNET/libnetconf2#478
jktjkt
added a commit
to CESNET/libnetconf2-cpp
that referenced
this pull request
Apr 10, 2024
This is really just a change of logging, nothing else. Unfortunately, the new logging still affects a global state, it was really just a change of the function signature, and the logger callback might well be invoked with a NULL session. This means that mapping from the nc_session* to a libnetconf::client::Session is not possible, so I though that simply providing an opaque pointer is not a bad solution. Change-Id: Iaa10855f4173fdd5e3046efa1827e4931cd05acb Depends-on: https://gerrit.cesnet.cz/c/CzechLight/libyang-cpp/+/7049 Depends-on: CESNET/libnetconf2#477 Depends-on: CESNET/libnetconf2#478
jktjkt
added a commit
to CESNET/CzechLight-dependencies
that referenced
this pull request
Apr 10, 2024
Change-Id: I64fc283d17075bd5236243cc7072b11b53570e48 Depends-on: https://gerrit.cesnet.cz/c/CzechLight/libyang-cpp/+/7049 Depends-on: https://gerrit.cesnet.cz/c/CzechLight/sysrepo-cpp/+/7033 Depends-on: https://gerrit.cesnet.cz/c/CzechLight/libnetconf2-cpp/+/7041 Depends-on: CESNET/libnetconf2#477 Depends-on: CESNET/libnetconf2#478
michalvasko
approved these changes
Apr 10, 2024
|
Okay, I think it can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #476 by:
You might not like the third commit, so feel free to cherry-pick what makes sense to you. I obviously still think that it's a bad idea to override a logger of another library like this, but in the end it's your call.