Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MbedTLS to libnetconf2 #485

Merged
merged 54 commits into from
May 14, 2024
Merged

Conversation

Roytak
Copy link
Collaborator

@Roytak Roytak commented May 13, 2024

Initial version of supporting MbedTLS in libnetconf2. Most notable included changes:

  • wrapper for OpenSSL/MbedTLS API calls
  • renamed NC_TI_LIBSSH & NC_TI_OPENSSL to NC_TI_SSH & NC_TI_TLS
  • refactored server-side TLS authentication to reflect ietf-tls-server's ca-certs container description
  • deprecated nc_connect_libssl()
  • client side TLS verification is left to the underlying TLS library (should only effect CRLs)
  • revoking certs based on CRLs is handled by the underlying TLS library
  • MbedTLS GitHub CI runs

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

CMakeModules/FindMbedTLS.cmake Outdated Show resolved Hide resolved
src/session.c Outdated Show resolved Hide resolved
src/session_mbedtls.c Outdated Show resolved Hide resolved
src/session_mbedtls.c Outdated Show resolved Hide resolved
@michalvasko michalvasko merged commit e27256b into CESNET:devel May 14, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants