-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support SSH authentication for non-configured users #487
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, I'm thrilled to see that the "system" behavior is back now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for my comment, I would add a fairly brief section into README called Supported YANG modules
or something similar mentioning what YANG modules with what features the library expects to be implemented and that there is a function that creates such a context. Mention also that this single feature can be disabled and also an explicit list of the YANG modules and their features, maybe aslo with a list of disabled features of all the modules. That way a concise summary of supported features of libnetconf2 will be included and can be updated as new features are supported.
Based on the value of the YANG feature
local-users-supported
the SSH server decides, whether to lookup authorized users from the configuration or from the system.Resolves #486