-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
distro UPDATE separate package for YANG modules #2209
Conversation
I do not like the idea of another separate package much. Moving it to the |
Actually I realized that putting the models into the Your idea of putting them into another directory for |
Hi @michalvasko, do you have any comment? We need to sort this out before the first release of |
While I recognize that some people are using libyang without sysrepo, I think that in the majority of deployments it will be libyang+sysrepo+netopeer2. Unless I'm mistaken, it is not possible to mix two different sysrpeo versions, so the odds of someone having libyang v2 and v3 at the same time and their systems still working are rather slim. Perhaps a simple package-level blocker might be enough? |
https://github.com/FRRouting/frr is using libyang and it's a pretty popular package. People may be using older versions of FRR which uses libyang2 on the same system with newer sysrepo which uses libyang3. It will work properly as libyang2/3 have different major SO versions. I don't see any reason to prohibit that. If you're ok with accepting the solution of putting the model files into a different directory then I'll update my PR. Removing this conflict between the packages is more important for me than having the models in a separate package. I just thought that a separate package is a more clear solution. |
Okay, after some consideration I am fine with having a separate package. You are right that they are not needed for libyang, they are being installed mostly to follow all the other projects that install their YANG modules and can be useful for other applications based on YANG. |
Currently, YANG modules are installed as part of the main libyang deb/rpm package. This makes it impossible to install both libyang2 and libyang3 at the same time, because package managers don't allow to simultaneously install packages that provide the same files. As the YANG modules are already embedded into libyang binaries and not needed for libyang operation, we can move them to a separate libyang-modules optional package. It allows to install both libyang2 and libyang3 at the same time. Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
Updated the package name to |
Alright, merging. |
Currently, YANG modules are installed as part of the main libyang deb/rpm package. This makes it impossible to install both libyang2 and libyang3 at the same time, because package managers don't allow to simultaneously install packages that provide the same files.
As the YANG modules are already embedded into libyang binaries and not needed for libyang operation, we can move them to a separate libyang-data optional package. It allows to install both libyang2 and libyang3 at the same time.
P.S. Another option is to install YANG modules as part of
libyang-dev
package. Please, let me know if you think it's a better option and I'll update my PR accordingly.