Use new libnetconf2 API #1492
Merged
Use new libnetconf2 API #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
November 2, 2023 10:42
The new libnetconf2 API can handle making changes to configuration by simply being given a diff. This means that (almost) all the callbacks and configuration API calls can be replaced by a single callback. Some command line opts are now redundant too.
Remove modules that are related to the ietf-netconf-server modules, because they are installed using libnetconf2's module dir.
Install ietf-netconf-server related modules from libnetconf2's schema dir, update default config with an only SSH user being the user who invoked the script and his password.
Also replace NC_ENABLED_SSH and NC_ENABLED_TLS macros by NC_ENABLED_SSH_TLS, because these macros were merged into one in ln2. Update to CMake 3.5.
Sets the env variable from which the modules will be loaded in a test. No longer wait for a socket to know that server is ready, instead wait for its pidfile. Create default UNIX socket manually, since the -U opt was removed from np2-srv as it's no longer needed.
Filters had to be added when getting config from DS in order for them to work like they did, because server config was getting in the way. Substring checking was used where it wasn't as simple.
Roytak
force-pushed
the
libnetconf4
branch
3 times, most recently
from
24800fb to
5bc8457
Compare
michalvasko
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.