-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for irregular grid in FindLinearIdx #204
Conversation
…interpolate properly using cell-averaged method for irregular DEM grid
So it looks like there's three general cases:
I'll test this this weekend and get back to you. |
Yes, that's right. I made a test (just modification of Example2) using the DEM used in the issue #203 and it seemed to fix that alignment using the updated varying grid spacings along the x/y axes. |
Could you send me this test please? |
Thinking about this logic, seems maybe a bit faulty.
This also could be the case for dy. I would make this
|
True that's a good change |
what I would like to see is a test in the |
Given that this problem has now appeared three times, it's important this doesn't happen again. |
fair enough, I can work on that. |
Let me know if you need any help |
…me region but with different resolution types (dx=dy, dx~=dy and varying dx~=dy)
Made a test using a subset of the CUDEM with different resolution types. Please check it out |
Made sure test does not pass with the previous interpolation method. |
Testing for irregular DEM grid in FindLinearIdx function in order tointerpolate properly using cell-averaged method for irregular DEM grid