Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read in existing auxiliary files into msh obj, updates to make_bc #287

Merged
merged 9 commits into from
Feb 23, 2024

Conversation

WPringle
Copy link
Collaborator

@WPringle WPringle commented May 30, 2023

Some additions for sponge zone construction, reading auxiliary files, writing offset63, swanoutput namelist, update Make_f5354 help and min_depth option.

…ect, this is called from when the kwarg is used, but now we can also use this feature without calling through msh() function
…rwise it converted the offset_values to integer)
…lling fro TPXO9-atlas solutions, (2( adding option for min_depth to be passed which is used as a lower limit of the depth used to divide tidal transport velocities by
@WPringle
Copy link
Collaborator Author

Sponge example:

% input files
mesh_file = 'my_mesh.mat'
tpxoh = 'h_**_tpxo9_atlas_30_v5.nc';
tpxou = 'u_**_tpxo9_atlas_30_v5.nc';

% load the mesh
load(mesh_file)

% add the sponge layer (width 10% of M2) 
sponge_opt = 1; % for tidal boundary conditions
m = Calc_Sponge(m,[12.42*3600, 0.1],sponge_opt);

%% Make the fort.15 struct
TS = start_time; %[date-string]
TE = end_time; %[date-string]
DT = time_step; %[s]
CONST = "major8"; % tidal constituent information
m = Make_f15(m,TS,TE,DT,'const',CONST,'tidal_database',tpxoh);

% add the sponge info for this tidal
m = Make_f5354(m, tpxoh, tpxou);
% write out mesh files..
write(m,'sponge_mesh')

@WPringle WPringle marked this pull request as ready for review February 19, 2024 16:32
Copy link
Collaborator

@krober10nd krober10nd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the ability to read in aux files using the msh.read() perhaps this could be added to the README as a code snippet and a short couple sentences?

@@ -157,9 +157,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)

### Unreleased (on current HEAD of the Projection branch)
## Added

- Added new function in `msh` called `remesh_patch` to remesh within specified polygonal domains and insert back into parent mesh.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please preserve the prior recently added items on the checklist.

@krober10nd
Copy link
Collaborator

The only other comment pending is regarding preserving the previous entries in the changelog. Otherwise good to go.

Longer description of msh.read() function additions
@krober10nd krober10nd merged commit 5154562 into Projection Feb 23, 2024
@krober10nd krober10nd deleted the enhancements/makebc_msh_read branch February 23, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants