-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
read in existing auxiliary files into msh obj, updates to make_bc #287
Conversation
…ect, this is called from when the kwarg is used, but now we can also use this feature without calling through msh() function
…rwise it converted the offset_values to integer)
…lling fro TPXO9-atlas solutions, (2( adding option for min_depth to be passed which is used as a lower limit of the depth used to divide tidal transport velocities by
Sponge example:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the ability to read in aux files using the msh.read()
perhaps this could be added to the README as a code snippet and a short couple sentences?
@@ -157,9 +157,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
|
|||
### Unreleased (on current HEAD of the Projection branch) | |||
## Added | |||
|
|||
- Added new function in `msh` called `remesh_patch` to remesh within specified polygonal domains and insert back into parent mesh. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please preserve the prior recently added items on the checklist.
The only other comment pending is regarding preserving the previous entries in the changelog. Otherwise good to go. |
Longer description of msh.read() function additions
Some additions for sponge zone construction, reading auxiliary files, writing offset63, swanoutput namelist, update Make_f5354 help and min_depth option.