Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #53

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Update README.md #53

merged 2 commits into from
Aug 12, 2024

Conversation

EvaMaeRey
Copy link
Contributor

micro suggestion... use labs instead of xlab ylab in example?

Description

I have a preference for using labs() generally, this makes it easier to remember how to make a quick legend label change too.

Proposed Changes

List changes below in bullet format:

  • xlab() -> labs(x =)

PR Checklist

Before submitting this PR, please check and verify below that the submission meets the below criteria:

  • New/revised functions have associated tests
  • New/revised functions that update downstream outputs have associated static testing files (.RDS) updated under inst/testdata/create_test_data.R
  • New/revised functions use appropriate naming conventions
  • New/revised functions don't repeat code
  • Code changes are less than 250 lines total
  • Issues linked to the PR using GitHub's list of keywords
  • The appropriate reviewer is assigned to the PR
  • The appropriate developers are assigned to the PR
  • Pre-release package version incremented using usethis::use_version()

Code Review

This section to be used by the reviewer and developers during Code Review after PR submission

Code Review Checklist

  • I checked that new files follow naming conventions and are in the right place
  • I checked that documentation is complete, clear, and without typos
  • I added/edited comments to explain "why" not "how"
  • I checked that all new variable and function names follow naming conventions
  • I checked that new tests have been written for key business logic and/or bugs that this PR fixes
  • I checked that new tests address important edge cases

micro suggestion... use labs instead of xlab ylab in example?
@rsh52
Copy link
Contributor

rsh52 commented Aug 12, 2024

micro suggestion... use labs instead of xlab ylab in example?

@EvaMaeRey Sure thing! Thank you for the suggestion. I will also update the README so it includes the arrow_data that I left out.

@rsh52 rsh52 self-requested a review August 12, 2024 14:54
@rsh52 rsh52 self-assigned this Aug 12, 2024
@rsh52 rsh52 added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 12, 2024
@rsh52 rsh52 merged commit 8ea54fe into CHOP-CGTInformatics:main Aug 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants