Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(deployment): fixed bootstrap and added separate appsets for sck/tds #196

Merged
merged 4 commits into from
Oct 11, 2024
Merged

feat(deployment): fixed bootstrap and added separate appsets for sck/tds #196

merged 4 commits into from
Oct 11, 2024

Conversation

iDmple
Copy link
Contributor

@iDmple iDmple commented Sep 26, 2024

Already applied.

@iDmple
Copy link
Contributor Author

iDmple commented Sep 26, 2024 •
edited
Loading

I'm having this warning when applying:

Warning: metadata.finalizers: "resources-finalizer.argocd.argoproj.io": prefer a domain-qualified finalizer name to avoid accidental conflicts with other finalizer writers

Should we use:

metadata:
  finalizers:
    - resources-finalizer.argocd.chorus-tre.ch

?

@greut
Copy link
Contributor

greut commented Sep 27, 2024

@iDmple unless you plan to fork ArgoCD, don't rename the finalizers they rely on.

@greut
Copy link
Contributor

greut commented Sep 27, 2024

Already applied.

Even for TDS?

Screenshot 2024-09-27 at 10-56-15 Applications List - Argo CD

@iDmple iDmple merged commit 3f3e862 into master Oct 11, 2024
1 check passed
@iDmple iDmple deleted the appsets branch October 11, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greut greut greut approved these changes

@floriansipp floriansipp Awaiting requested review from floriansipp floriansipp is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iDmple @greut