Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QC False Failures Fix #145

Merged

Conversation

mattdturner
Copy link
Contributor

Update QC script to properly handle cases when data in either hemisphere is bit-for-bit.

  • Developer(s): Matthew Turner

  • Please suggest code Pull Request reviewers in the column at right.

  • Are the code changes bit for bit, different at roundoff level, or more substantial? bfb

  • Is the documentation being updated with this PR? (Y/N) N
    If not, does the documentation need to be updated separately at a later time? (Y/N) N
    Note: "Documentation" includes information on the wiki and .rst files in doc/source/,
    which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.

  • Other Relevant Details:

@JFLemieux73
Copy link
Contributor

Thanks Matt. I just tested it with the new script. It works:

INFO:main:Number of files: 1833
INFO:main:Two-Stage Test Passed
INFO:main:Quadratic Skill Test Passed for Northern Hemisphere
INFO:main:Southern Hemisphere data is bit-for-bit
INFO:main:
INFO:main:Quality Control Test PASSED

@eclare108213 eclare108213 merged commit 5a5ea52 into CICE-Consortium:master Jun 1, 2018
@mattdturner mattdturner deleted the qc_bfb_false_failures branch August 9, 2018 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants