Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pgi compiler optimization to address reproducibility problems #187

Merged
merged 1 commit into from
Sep 20, 2018

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Sep 20, 2018

Update pgi compiler optimization, switch from O2 to O.

  • Developer(s): tcraig

  • Are the code changes bit for bit, different at roundoff level, or more substantial? NOT bit-for-bit for pgi compiler, but this is good.

  • Is the documentation being updated with this PR? (Y/N) N
    If not, does the documentation need to be updated separately at a later time? (Y/N) N

  • Other Relevant Details:

Confirmed that O0, O1, and O all generate results that are reproducible as expected (different block sizes, etc). O2 does not. O is between O1 and O2 and seems to actually perform better than O2 on conrad and gordon.

@apcraig
Copy link
Contributor Author

apcraig commented Sep 20, 2018

@eclare108213, I would like to get this onto the master in the next day so it's part of the weekend testing on conrad and gordon. This will establish a full set of new baselines for the pgi compiler to make it easier to test other change (like dynamic allocation). This will change answers which I believe is a good thing.

Feel free to review and Pull, this is ready and has been tested, hash 9a08fd8 on https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks

Copy link
Contributor

@eclare108213 eclare108213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. If someone else runs into pgi compiler problems, I'm sure we'll hear about it...

Copy link
Contributor

@eclare108213 eclare108213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, do you want -g even when the ICE_BLDDEBUG flag is false?

@apcraig
Copy link
Contributor Author

apcraig commented Sep 20, 2018

The -g doesn't hurt for these runs. I would leave -g for now. pgi is so unreliable as it is.

Also, I have change the pgi settings for all our pgi machines, conrad and gordon. Those are the only machines we test pgi on right now.

@eclare108213 eclare108213 merged commit 3b78bd0 into CICE-Consortium:master Sep 20, 2018
@apcraig apcraig deleted the pgiopt branch August 17, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants