Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OMP threading issue with dfresh and dfsalt #228

Merged
merged 1 commit into from
Nov 5, 2018
Merged

Fix OMP threading issue with dfresh and dfsalt #228

merged 1 commit into from
Nov 5, 2018

Conversation

dabail10
Copy link
Contributor

@dabail10 dabail10 commented Nov 5, 2018

Found an OMP threading bug with two of the SIMIP variables.

  • Developer(s): D. Bailey

  • Please suggest code Pull Request reviewers in the column at right.

  • Are the code changes bit for bit, different at roundoff level, or more substantial? BFB, except for two history variables: siflsaltbot and siflfwbot.

  • Please include the link to test results or paste the summary block from the bottom of the testing output below.

  • Does this PR create or have dependencies on Icepack or any other models? N

  • Is the documentation being updated with this PR? (Y/N) N
    If not, does the documentation need to be updated separately at a later time? (Y/N) N

Note: "Documentation" includes information on the wiki and .rst files in doc/source/,
which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.

  • Other Relevant Details:

@dabail10 dabail10 requested a review from apcraig November 5, 2018 16:34
@apcraig apcraig merged commit e2ca59c into CICE-Consortium:master Nov 5, 2018
@mhrib
Copy link
Contributor

mhrib commented Nov 6, 2018

Nice catch!
It was also one of the issues that causes problems with evp-kernel (#205) and for my tests of "HYCOM forcing read" (#224).

rgs
Mads

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants