Hycom forcing v2 + small adds / corrections

[mhrib]

This PR replace #224:

• Basal stress stuff deleted from this PR (similar to Code to read new bathymetry files for basal stress parameterization. #222)

--o--

1. Subroutines for reading HYCOM initial SST+SSS forcing and HYCOM atmospheric forcing input in NetCDF format
2. Minor corrections in popgrid_nc in ice_grid.F90: All records are the first - unlike for binary file formats
3. Add m_per_sec as precipitation unit option
4. Add "h" (hour) as accepted unit for restart-file-dump interval
5. Add optional input argument to "ice_open" subroutine in ice_read_write.f90. This makes it ready to read binary files structured in fixed size blocks as eg. used by HYCOM.

--o--

Developer(s): Mads Hvid Ribergaard, DMI

Please suggest code Pull Request reviewers in the column at right.

Tony??

Are the code changes bit for bit, different at roundoff level, or more substantial?
Yes, BFB

Please include the link to test results or paste the summary block from the bottom of the testing output below.

Does this PR create or have dependencies on Icepack or any other models?

Is the documentation being updated with this PR? (Y/N)

Yes. File updated: doc/source/user_guide/ug_case_settings.rst

If not, does the documentation need to be updated separately at a later time? (Y/N)

Note: "Documentation" includes information on the wiki and .rst files in doc/source/,
which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.

Other Relevant Details:

ad 1) HYCOM forcing:
Do not conflict with other stuff. But nice to have for DMI :-)

ad 2) "popgrid_nc" record-numbers in ice_grid.F90
Corrected all nrec to 1, as it is the first record that is needed for each variables: htn, hte, kmt, etc.
There is ONLY one record for each variable! This is different from "popgrid"-binary, which consists of 7 variables - ie. need a specific record number.

ad 3)+4): Simple adds

ad 5) Nice to have option, which DMI have used previous and may continue to use.

[apcraig]

This looks OK, but I may run a test suite on the changes. I assume there is no way to test the hycom forcing option at this point within the consortium? Is it worth adding some input data and setting that up?

[duvivier]

I would prefer this just be called "hycom" not "hycom_atm". This is how you did it for ocn_data_type and is consistent with the other options (e.g. "ncar" or "clim").

[duvivier]

I left two specific comments for changes to "hycom_am" and requesting you fix a typo I just noticed but not introduced by you. thanks!

[mhrib]

Fixed: * "hycom_atm" -> "hycom" option * "near" -> "ncar" Affected files: doc/source/user_guide/ug_case_settings.rst cicecore/cicedynB/general/ice_forcing.F90 rgs Mads

…

________________________________________ From: Alice DuVivier <notifications@github.com> Sent: Tuesday, November 6, 2018 18:48 To: CICE-Consortium/CICE Cc: Mads Hvid Ribergaard; Author Subject: Re: [CICE-Consortium/CICE] Hycom forcing v2 + small adds / corrections (#230) @duvivier requested changes on this pull request. I left two specific comments for changes to "hycom_am" and requesting you fix a typo I just noticed but not introduced by you. thanks! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#230 (review)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AkUFxZbMMTBh2U_8r6kIUJyuiOvVmitJks5uscuFgaJpZM4YQRr9>.

[mhrib]

I have no problems leaving this out of normal tests. However, if you prefer, I can provide pseudo hycom ocean (SST+SSS fixed fields) and hycom atm (time varying) NetCDF data interpolated to GX3? rgs Mads

…

________________________________________ From: Tony Craig <notifications@github.com> Sent: Tuesday, November 6, 2018 18:20 To: CICE-Consortium/CICE Cc: Mads Hvid Ribergaard; Author Subject: Re: [CICE-Consortium/CICE] Hycom forcing v2 + small adds / corrections (#230) @apcraig commented on this pull request. This looks OK, but I may run a test suite on the changes. I assume there is no way to test the hycom forcing option at this point within the consortium? Is it worth adding some input data and setting that up? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#230 (review)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AkUFxYqAsn9CKoQPauu8pK7pSkywhBIQks5uscTsgaJpZM4YQRr9>.