Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HYCOM forcing: follow HYCOM notation: ewndsp,nwndsp --> wndewd,wndnwd #425

Merged
merged 1 commit into from
Apr 10, 2020
Merged

HYCOM forcing: follow HYCOM notation: ewndsp,nwndsp --> wndewd,wndnwd #425

merged 1 commit into from
Apr 10, 2020

Conversation

mhrib
Copy link
Contributor

@mhrib mhrib commented Mar 31, 2020

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

  • Short (1 sentence) summary of your PR:
    Rename "HYCOM" forcing files according to HYCOM naming
  • Developer(s):
    Mads Hvid Ribergaard, DMI
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    ENTER INFORMATION HERE
  • How much do the PR code changes differ from the unmodified code?
    • [x ] bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • [x ] No
  • Does this PR add any new test cases?
    • Yes
    • [ x] No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • [ x] No, does the documentation need to be updated at a later time?
      • Yes
      • [x ] No
  • [x ] Please provide any additional information or relevant details below:
    The non-standard HYCOM naming for 10m windspeed is comming from DMI. Now back to standard

@apcraig apcraig self-assigned this Mar 31, 2020
@apcraig apcraig merged commit 85ba54d into CICE-Consortium:master Apr 10, 2020
@mhrib mhrib deleted the hycom_forcing branch April 16, 2020 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apcraig apcraig apcraig approved these changes

Assignees

@apcraig apcraig

Labels
Forcing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhrib @apcraig