-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add restart_coszen namelist option #480
Conversation
Update CICE for coupling with UFS
…l temperature and density are satisfied
changes to satisfy ufsatm and cesm requirements for pot temp and density from atm
This reverts commit e70d1ab.
cleanup changes to nuopc branch
See issue #486 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see a cpp moved to namelist.
@eclare108213, do you want to have a review before we merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do changes also need to be made in io_binary/ice_restart.F90?
I would probably have put this new namelist flag in forcing_nml, since it's for a specific variable. We also have specific restart_[] flags in tracer_nml and zbgc_nml, for example. Maybe we should collect these into a new 'restart_nml' namelist, but not in this PR.
I just noticed an error in the documentation: in doc/source/user_guide_ug_case_settings.rst, please change 'restart' to 'history' in the comments for history_format. Thanks!
Not sure that any coupled models use the binary restarts any longer, but I suppose this is a good plan. |
Maybe this is more appropriate in shortwave_nml? |
Actually, this is already handled for binary, because it is called from the generic write_restart_field/read_restart_field subroutines that are agnostic to the format. It's almost like someone designed them this way ... :) |
You could do that. My preference would still be forcing_nml, since coszen really is about the forcing, and the parameters in shortwave_nml are specific to the shortwave parameterizations. |
I've moved restart_coszen to the shortwave_nml namelist. I also made the updates to the documentation. |
For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers
PR checklist
This adds a namelist option for adding coszen to the restart. This removes the need for CESMCOUPLED here.
dabail10 (D. Bailey)
https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_mach_forks#cheyenne
Several coupled models will need coszen on the restart file. This makes it a namelist option instead of an ifdef.