cice.setup: remove 'suite.jobs' at start of 'suite.submit' #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running a test suite that includes 'bfbcomp' tests, the test
script ('cice.test') queries the file 'suite.jobs' in the suite
directory to get the job ID of the test against which to compare for
bit-for-bit-ness.
If re-running the suite, 'suite.jobs' is not removed, so that the new
job IDs are appended to the existing file. This leads to syntax errors
when 'cice.test' looks for the job ID to compare against since the
'grep' call returns several matches.
Remove 'suite.jobs' at the start of the 'suite.submit' script generated
by 'cice.setup' to avoid that.
apcraig
approved these changes
Jul 14, 2022
|
Upon further investigation, I realize that Icepack's |
dabail10
pushed a commit
to ESCOMP/CICE
that referenced
this pull request
Oct 4, 2022
…ortium#731) When running a test suite that includes 'bfbcomp' tests, the test script ('cice.test') queries the file 'suite.jobs' in the suite directory to get the job ID of the test against which to compare for bit-for-bit-ness. If re-running the suite, 'suite.jobs' is not removed, so that the new job IDs are appended to the existing file. This leads to syntax errors when 'cice.test' looks for the job ID to compare against since the 'grep' call returns several matches. Remove 'suite.jobs' at the start of the 'suite.submit' script generated by 'cice.setup' to avoid that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
title
me
tested it works.
When running a test suite that includes 'bfbcomp' tests, the test
script ('cice.test') queries the file 'suite.jobs' in the suite
directory to get the job ID of the test against which to compare for
bit-for-bit-ness.
If re-running the suite, 'suite.jobs' is not removed, so that the new
job IDs are appended to the existing file. This leads to syntax errors
when 'cice.test' looks for the job ID to compare against since the
'grep' call returns several matches.
Remove 'suite.jobs' at the start of the 'suite.submit' script generated
by 'cice.setup' to avoid that.