Plugin Sniffer: Map Asynchronous Loading #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I need a little control over script loading order to make the sniffer map work with pjax
brauliobo
added a commit
that referenced
this pull request
Apr 17, 2015
Plugin Sniffer: Map Asynchronous Loading
|
server restarting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need a little control over script loading order to make the sniffer map work with pjax, since pjax evaluate external scripts from content asynchronously. I see you mentioned this behavior in an issue (defunkt/jquery-pjax#331) but so far there isn't a clear solution. In our case, we need the google map api to complete loading before evaluating
infobox.jsandcustom_marker.js. There is a downside of my solution, since the scripts can possibly be loaded more than once, but I don't see another way to make this work with pjax and there doesn't seem to be consequences for the user experience. By the way, if you see a better way of doing this, I'm open for suggestions :)