ci: include windows 2022 #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #748 +/- ##
=======================================
Coverage 99.06% 99.06%
=======================================
Files 16 16
Lines 3964 3964
=======================================
Hits 3927 3927
Misses 37 37
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
I think I fixed the VS2022 issue, seemed to be something with C++20 changes to allowed constructors for std::array that messed up some of the template type detections. |
phlptp
force-pushed
the
henryiii/ci/win23
branch
from
04266a0 to
8ea40a9
Compare
|
@henryiii not sure what is going on with the pre-commit error. |
|
Curious. Pre-commit updated a few days ago, but no node changes afaict, that’s all I see that’s changed. Can check soonish, currently at SciPy. |
github-actions
bot
added
needs changelog
henryiii
removed
needs changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be broken.